Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8a3de8d authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

spi: tegra114: Add missing IRQ check in tegra_spi_probe 



[ Upstream commit 4f92724d4b92c024e721063f520d66e11ca4b54b ]

This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: f333a331 ("spi/tegra114: add spi driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165238.25615-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e5e748a6

drivers/spi/spi-tegra114.c

+4 −0
Original line number Diff line number Diff line
@@ -1352,6 +1352,10 @@ static int tegra_spi_probe(struct platform_device *pdev) 
	tspi->phys = r->start;



	spi_irq = platform_get_irq(pdev, 0);

	if (spi_irq < 0) {

		ret = spi_irq;

		goto exit_free_master;

	}

	tspi->irq = spi_irq;



	tspi->clk = devm_clk_get(&pdev->dev, "spi");