Commit f89adeda authored Apr 30, 2019 by Gal Pressman Committed by Jason Gunthorpe May 02, 2019

RDMA/uverbs: Initialize udata struct on destroy flows



Cited commit introduced the udata parameter to different destroy flows
but the uapi method definition does not have udata (i.e has_udata flag
is not set). As a result, an uninitialized udata struct is being passed
down to the driver callbacks.

Fix that by clearing the driver udata even in cases where has_udata flag
is not set.

Fixes: c4367a26 ("IB: Pass uverbs_attr_bundle down ib_x destroy path")
Cc: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
Co-developed-by: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 7872168a

drivers/infiniband/core/uverbs_ioctl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -453,6 +453,8 @@ static int ib_uverbs_run_method(struct bundle_priv *pbundle,
		uverbs_fill_udata(&pbundle->bundle,
		&pbundle->bundle.driver_udata,
		UVERBS_ATTR_UHW_IN, UVERBS_ATTR_UHW_OUT);
		else
		pbundle->bundle.driver_udata = (struct ib_udata){};

		if (destroy_bkey != UVERBS_API_ATTR_BKEY_LEN) {
		struct uverbs_obj_attr *destroy_attr =