Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8261c37 authored by Dan Carpenter's avatar Dan Carpenter Committed by Lucas Stach
Browse files

drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump() 



The etnaviv_gem_get_pages() never returns NULL.  It returns error
pointers on error.

Fixes: a8c21a54 ("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
parent a20ca674

drivers/gpu/drm/etnaviv/etnaviv_dump.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -215,7 +215,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) 
		mutex_lock(&obj->lock);

		mutex_lock(&obj->lock);

		pages = etnaviv_gem_get_pages(obj);

		pages = etnaviv_gem_get_pages(obj);

		mutex_unlock(&obj->lock);

		mutex_unlock(&obj->lock);

		if (pages) {

		if (!IS_ERR(pages)) {

			int j;

			int j;





			iter.hdr->data[0] = bomap - bomap_start;

			iter.hdr->data[0] = bomap - bomap_start;