Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7f24d67 authored by Guillaume Stols's avatar Guillaume Stols Committed by Greg Kroah-Hartman
Browse files

iio: adc: ad7606: fix standby gpio state to match the documentation 



[ Upstream commit 059fe4f8bbdf5cad212e1aeeb3e8968c80b9ff3b ]

The binding's documentation specifies that "As the line is active low, it
should be marked GPIO_ACTIVE_LOW". However, in the driver, it was handled
the opposite way. This commit sets the driver's behaviour in sync with the
documentation

Fixes: 722407a4 ("staging:iio:ad7606: Use GPIO descriptor API")
Signed-off-by: default avatarGuillaume Stols <gstols@baylibre.com>
Reviewed-by: default avatarNuno Sa <nuno.sa@analog.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d44f8a17

drivers/iio/adc/ad7606.c

+2 −2
Original line number Diff line number Diff line
@@ -445,7 +445,7 @@ static int ad7606_request_gpios(struct ad7606_state *st) 
		return PTR_ERR(st->gpio_range);



	st->gpio_standby = devm_gpiod_get_optional(dev, "standby",

						   GPIOD_OUT_HIGH);

						   GPIOD_OUT_LOW);

	if (IS_ERR(st->gpio_standby))

		return PTR_ERR(st->gpio_standby);
@@ -706,7 +706,7 @@ static int ad7606_suspend(struct device *dev) 


	if (st->gpio_standby) {

		gpiod_set_value(st->gpio_range, 1);

		gpiod_set_value(st->gpio_standby, 0);

		gpiod_set_value(st->gpio_standby, 1);

	}



	return 0;