Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7e9e230 authored by Amerigo Wang's avatar Amerigo Wang Committed by David S. Miller
Browse files

qlge: remove NETIF_F_TSO6 flag 

It is werid that qlge driver supports NETIF_F_TSO6 but
not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1]
when VLAN device setups on a qlge interface.

I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM,
so we have to just remove the NETIF_F_TSO6 flag.

After this patch, the TCP/IPv6 traffic becomes normal again,
no kernel warnings any more.

NOTE: I only tested it on 2.6.32 kernel, even if the upstream
kernel could fix this automatically (it is hard to track NETIF*
flags), removing it is also safe.

1. https://bugzilla.redhat.com/show_bug.cgi?id=891839



Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>
Cc: linux-driver@qlogic.com
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarCong Wang <amwang@redhat.com>
Acked-by: default avatarJitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b514a88

drivers/net/ethernet/qlogic/qlge/qlge_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4678,7 +4678,7 @@ static int qlge_probe(struct pci_dev *pdev, 
	qdev = netdev_priv(ndev);

	SET_NETDEV_DEV(ndev, &pdev->dev);

	ndev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |

		NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN |

		NETIF_F_TSO | NETIF_F_TSO_ECN |

		NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;

	ndev->features = ndev->hw_features |

		NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;