Commit f7b3b520 authored Mar 10, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Mar 16, 2022

gianfar: ethtool: Fix refcount leak in gfar_get_ts_info



[ Upstream commit 2ac5b58e645c66932438bb021cb5b52097ce70b0 ]

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: 7349a74e ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Link: https://lore.kernel.org/r/20220310015313.14938-1-linmq006@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 54fd6b2e

drivers/net/ethernet/freescale/gianfar_ethtool.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1489,6 +1489,7 @@ static int gfar_get_ts_info(struct net_device *dev,
		ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp");
		if (ptp_node) {
		ptp_dev = of_find_device_by_node(ptp_node);
		of_node_put(ptp_node);
		if (ptp_dev)
		ptp = platform_get_drvdata(ptp_dev);
		}