Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f79e3365 authored Jan 23, 2019 by Gustavo A. R. Silva Committed by David S. Miller Jan 23, 2019

tipc: mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

net/tipc/link.c:1125:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
net/tipc/socket.c:736:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
net/tipc/socket.c:2418:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f1164653

net/tipc/link.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1126,7 +1126,7 @@ static bool tipc_data_input(struct tipc_link l, struct sk_buff skb,
		skb_queue_tail(mc_inputq, skb);
		return true;
		}
		/* else: fall through */
		/* fall through */
		case CONN_MANAGER:
		skb_queue_tail(inputq, skb);
		return true;

net/tipc/socket.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -735,7 +735,7 @@ static __poll_t tipc_poll(struct file file, struct socket sock,
		case TIPC_CONNECTING:
		if (!tsk->cong_link_cnt && !tsk_conn_cong(tsk))
		revents \|= EPOLLOUT;
		/* fall thru' */
		/* fall through */
		case TIPC_LISTEN:
		if (!skb_queue_empty(&sk->sk_receive_queue))
		revents \|= EPOLLIN \| EPOLLRDNORM;
		@@ -2416,7 +2416,7 @@ static int tipc_connect(struct socket sock, struct sockaddr dest,
		* case is EINPROGRESS, rather than EALREADY.
		*/
		res = -EINPROGRESS;
		/* fall thru' */
		/* fall through */
		case TIPC_CONNECTING:
		if (!timeout) {
		if (previous == TIPC_CONNECTING)