Commit f79b55d9 authored Mar 25, 2018 by Wei Yongjun Committed by Linus Walleij Mar 27, 2018

gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()



platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
[albeu@free.fr: Fixed patch to apply on current tree]
Signed-off-by: Alban Bedel <albeu@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 89b0b4e2

drivers/gpio/gpio-ath79.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -258,6 +258,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
		}

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!res)
		return -EINVAL;
		ctrl->base = devm_ioremap_nocache(
		&pdev->dev, res->start, resource_size(res));
		if (!ctrl->base)