Commit f785ffb6 authored Jan 16, 2019 by Neo Hou Committed by Bartosz Golaszewski Jan 23, 2019

gpio: sprd: Fix incorrect irq type setting for the async EIC



When setting async EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the
SPRD_EIC_ASYNC_INTMODE register to 0, which means detecting edge signals.

Thus this patch fixes the issue.

Fixes: 25518e02 ("gpio: Add Spreadtrum EIC driver support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Neo Hou <neo.hou@unisoc.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 09d158d5

drivers/gpio/gpio-eic-sprd.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -379,6 +379,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
		irq_set_handler_locked(data, handle_edge_irq);
		break;
		case IRQ_TYPE_EDGE_BOTH:
		sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
		sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
		irq_set_handler_locked(data, handle_edge_irq);
		break;