Commit f729b74b authored Mar 24, 2023 by Tomas Henzl Committed by Greg Kroah-Hartman Apr 26, 2023

scsi: megaraid_sas: Fix fw_crash_buffer_show()



[ Upstream commit 0808ed6ebbc292222ca069d339744870f6d801da ]

If crash_dump_buf is not allocated then crash dump can't be available.
Replace logical 'and' with 'or'.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Link: https://lore.kernel.org/r/20230324135249.9733-1-thenzl@redhat.com


Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4f4ef354

drivers/scsi/megaraid/megaraid_sas_base.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3235,7 +3235,7 @@ fw_crash_buffer_show(struct device *cdev,

		spin_lock_irqsave(&instance->crashdump_lock, flags);
		buff_offset = instance->fw_crash_buffer_offset;
		if (!instance->crash_dump_buf &&
		if (!instance->crash_dump_buf \|\|
		!((instance->fw_crash_state == AVAILABLE) \|\|
		(instance->fw_crash_state == COPYING))) {
		dev_err(&instance->pdev->dev,