Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f72429fc authored by Pawel Laszczak's avatar Pawel Laszczak Committed by Felipe Balbi
Browse files

usb: common: Simplify usb_decode_get_set_descriptor function. 



Patch moves switch responsible for decoding descriptor type
outside snprintf. It improves code readability a little.

Signed-off-by: default avatarPawel Laszczak <pawell@cadence.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 010665b4

drivers/usb/common/debug.c

+58 −55
Original line number Diff line number Diff line
@@ -105,9 +105,8 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest, 
					  __u16 wValue, __u16 wIndex,

					  __u16 wLength, char *str, size_t size)

{

	snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)",

		 bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",

		 ({ char *s;

	char *s;



	switch (wValue >> 8) {

	case USB_DT_DEVICE:

		s = "Device";
@@ -160,7 +159,11 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest, 
	default:

		s = "UNKNOWN";

		break;

			} s; }), wValue & 0xff, wLength);

	}



	snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)",

		bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",

		s, wValue & 0xff, wLength);

}



static void usb_decode_get_configuration(__u16 wLength, char *str, size_t size)