Commit f6d3aee1 authored Feb 02, 2023 by Greg Kroah-Hartman

kernel/fail_function: fix memory leak with using debugfs_lookup()



[ Upstream commit 2bb3669f576559db273efe49e0e69f82450efbca ]

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230202151633.2310897-1-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 195c1e9f

kernel/fail_function.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -163,10 +163,7 @@ static void fei_debugfs_add_attr(struct fei_attr *attr)

		static void fei_debugfs_remove_attr(struct fei_attr *attr)
		{
		struct dentry *dir;

		dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
		debugfs_remove_recursive(dir);
		debugfs_lookup_and_remove(attr->kp.symbol_name, fei_debugfs_dir);
		}

		static int fei_kprobe_handler(struct kprobe kp, struct pt_regs regs)