Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f60deecb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with a
"fall through" annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114976 ("Missing break in switch")
Addresses-Coverity-ID: 114977 ("Missing break in switch")
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent bf9598bd

drivers/scsi/lpfc/lpfc_hbadisc.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -4667,9 +4667,11 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba, 
		case CMD_GEN_REQUEST64_CR:

		case CMD_GEN_REQUEST64_CR:

			if (iocb->context_un.ndlp == ndlp)

			if (iocb->context_un.ndlp == ndlp)

				return 1;

				return 1;

			/* fall through */

		case CMD_ELS_REQUEST64_CR:

		case CMD_ELS_REQUEST64_CR:

			if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID)

			if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID)

				return 1;

				return 1;

			/* fall through */

		case CMD_XMIT_ELS_RSP64_CX:

		case CMD_XMIT_ELS_RSP64_CX:

			if (iocb->context1 == (uint8_t *) ndlp)

			if (iocb->context1 == (uint8_t *) ndlp)

				return 1;

				return 1;
@@ -5856,7 +5858,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport) 




	case LPFC_LINK_UP:

	case LPFC_LINK_UP:

		lpfc_issue_clear_la(phba, vport);

		lpfc_issue_clear_la(phba, vport);

		/* Drop thru */

		/* fall through */

	case LPFC_LINK_UNKNOWN:

	case LPFC_LINK_UNKNOWN:

	case LPFC_WARM_START:

	case LPFC_WARM_START:

	case LPFC_INIT_START:

	case LPFC_INIT_START: