Commit f5b76a81 authored Jan 26, 2023 by Harshit Mogalapalli Committed by Greg Kroah-Hartman Mar 11, 2023

iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()



[ Upstream commit 64a68158738ec8f520347144352f7a09bdb9e169 ]

Smatch Warns:
drivers/iio/accel/mma9551_core.c:299
	mma9551_read_config_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: No actual bug as caller checks the return value and does not
use the parameter in the problem case.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126153610.3586243-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 11b4b3b7

drivers/iio/accel/mma9551_core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -296,9 +296,12 @@ int mma9551_read_config_word(struct i2c_client *client, u8 app_id,

		ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_CONFIG,
		reg, NULL, 0, (u8 *)&v, 2);
		if (ret < 0)
		return ret;

		*val = be16_to_cpu(v);

		return ret;
		return 0;
		}
		EXPORT_SYMBOL(mma9551_read_config_word);