Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5ab7987 authored by Subbaraman Narayanamurthy's avatar Subbaraman Narayanamurthy
Browse files

leds: qti-flash: Handle error return path properly 



Currently if qti_flash_lmh_mitigation_config() returns an error
in qti_flash_led_strobe(), spin_unlock() is not called in the
error return path. Fix it.

Fixes: 42bdecad ("leds: qti-flash: Fix LMH mitigation configuration")
Change-Id: I1bede93873a151cc9bab7f2000d8f058e1890fda
Signed-off-by: default avatarSubbaraman Narayanamurthy <subbaram@codeaurora.org>
parent d8534164

drivers/leds/leds-qti-flash.c

+2 −2
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ static int qti_flash_led_strobe(struct qti_flash_led *led, 
		if (led->trigger_lmh) {

			rc = qti_flash_lmh_mitigation_config(led, true);

			if (rc < 0)

				return rc;

				goto error;



			/* Wait for LMH mitigation to take effect */

			udelay(500);
@@ -386,7 +386,7 @@ static int qti_flash_led_strobe(struct qti_flash_led *led, 
		if (led->trigger_lmh) {

			rc = qti_flash_lmh_mitigation_config(led, false);

			if (rc < 0)

				return rc;

				goto error;



			led->trigger_lmh = false;

		}