Commit f58c8563 authored May 05, 2023 by Yuchen Yang Committed by Greg Kroah-Hartman Jul 27, 2023

scsi: 3w-xxxx: Add error handling for initialization failure in tw_probe()



[ Upstream commit 2e2fe5ac695a00ab03cab4db1f4d6be07168ed9d ]

Smatch complains that:

tw_probe() warn: missing error code 'retval'

This patch adds error checking to tw_probe() to handle initialization
failure. If tw_reset_sequence() function returns a non-zero value, the
function will return -EINVAL to indicate initialization failure.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Yuchen Yang <u202114568@hust.edu.cn>
Link: https://lore.kernel.org/r/20230505141259.7730-1-u202114568@hust.edu.cn


Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 666e7f9d

drivers/scsi/3w-xxxx.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2310,8 +2310,10 @@ static int tw_probe(struct pci_dev pdev, const struct pci_device_id dev_id)
		TW_DISABLE_INTERRUPTS(tw_dev);

		/* Initialize the card */
		if (tw_reset_sequence(tw_dev))
		if (tw_reset_sequence(tw_dev)) {
		retval = -EINVAL;
		goto out_release_mem_region;
		}

		/* Set host specific parameters */
		host->max_id = TW_MAX_UNITS;