Commit f55adad6 authored Dec 10, 2018 by Keith Busch Committed by Jens Axboe Dec 10, 2018

block/bio: Do not zero user pages



We don't need to zero fill the bio if not using kernel allocated pages.

Fixes: f3587d76 ("block: Clear kernel memory before copying to user") # v4.20-rc2
Reported-by: Todd Aiken <taiken@mvtech.ca>
Cc: Laurence Oberman <loberman@redhat.com>
Cc: stable@vger.kernel.org
Cc: Bart Van Assche <bvanassche@acm.org>
Tested-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 8b878ee2

block/bio.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1261,6 +1261,7 @@ struct bio bio_copy_user_iov(struct request_queue q,
		if (ret)
		goto cleanup;
		} else {
		if (bmd->is_our_pages)
		zero_fill_bio(bio);
		iov_iter_advance(iter, bio->bi_iter.bi_size);
		}