Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f53729b8 authored by Sanket Parmar's avatar Sanket Parmar Committed by Greg Kroah-Hartman
Browse files

usb: cdns3: Enable TDL_CHK only for OUT ep 



commit d6eef886903c4bb5af41b9a31d4ba11dc7a6f8e8 upstream.

ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used
as TDL source for IN endpoints. To fix it, TDL_CHK is only
enabled for OUT endpoints.

Fixes: 7733f6c3 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reported-by: default avatarAswath Govindraju <a-govindraju@ti.com>
Signed-off-by: default avatarSanket Parmar <sparmar@cadence.com>
Link: https://lore.kernel.org/r/1621263912-13175-1-git-send-email-sparmar@cadence.com


Signed-off-by: default avatarPeter Chen <peter.chen@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 52b01a80

drivers/usb/cdns3/gadget.c

+3 −5
Original line number Diff line number Diff line
@@ -1531,7 +1531,7 @@ void cdns3_configure_dmult(struct cdns3_device *priv_dev, 
		else

			mask = BIT(priv_ep->num);



		if (priv_ep->type != USB_ENDPOINT_XFER_ISOC) {

		if (priv_ep->type != USB_ENDPOINT_XFER_ISOC  && !priv_ep->dir) {

			cdns3_set_register_bit(&regs->tdl_from_trb, mask);

			cdns3_set_register_bit(&regs->tdl_beh, mask);

			cdns3_set_register_bit(&regs->tdl_beh2, mask);
@@ -1569,15 +1569,13 @@ void cdns3_ep_config(struct cdns3_endpoint *priv_ep) 
	case USB_ENDPOINT_XFER_INT:

		ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT);



		if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||

		    priv_dev->dev_ver > DEV_VER_V2)

		if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)

			ep_cfg |= EP_CFG_TDL_CHK;

		break;

	case USB_ENDPOINT_XFER_BULK:

		ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK);



		if ((priv_dev->dev_ver == DEV_VER_V2  && !priv_ep->dir) ||

		    priv_dev->dev_ver > DEV_VER_V2)

		if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)

			ep_cfg |= EP_CFG_TDL_CHK;

		break;

	default: