Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5109187 authored by lixiang's avatar lixiang Committed by Gerrit - the friendly Code Review server
Browse files

soc: qcom: hab: Fix potential memory leak when receiving msg 



Fix potential memory leak situation when receiving a message of type
HAB_PAYLOAD_TYPE_EXPORT_ACK. Add kfree() to free ack_recvd.

Change-Id: Iaa5cb10af694b20647f2f04f3c030bfa2ba59a3d
Signed-off-by: default avatarlixiang <lixiang@codeaurora.org>
parent adc03f0e

drivers/soc/qcom/hab/hab_msg.c

+4 −1
Original line number Diff line number Diff line
@@ -163,13 +163,16 @@ static int hab_receive_create_export_ack(struct physical_channel *pchan, 
	if (sizebytes > sizeof(ack_recvd->ack)) {

		pr_err("pchan %s read size too large %zd %zd\n",

			pchan->name, sizebytes, sizeof(ack_recvd->ack));

		kfree(ack_recvd);

		return -EINVAL;

	}



	if (physical_channel_read(pchan,

		&ack_recvd->ack,

		sizebytes) != sizebytes)

		sizebytes) != sizebytes) {

		kfree(ack_recvd);

		return -EIO;

	}



	hab_spin_lock(&ctx->expq_lock, irqs_disabled);

	list_add_tail(&ack_recvd->node, &ctx->exp_rxq);