Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4f2acf0 authored by Florian Westphal's avatar Florian Westphal Committed by Greg Kroah-Hartman
Browse files

plip: avoid rcu debug splat 



commit bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32 upstream.

WARNING: suspicious RCU usage
5.2.0-rc2-00605-g2638eb8b50cfc #1 Not tainted
drivers/net/plip/plip.c:1110 suspicious rcu_dereference_check() usage!

plip_open is called with RTNL held, switch to the correct helper.

Fixes: 2638eb8b ("net: ipv4: provide __rcu annotation for ifa_list")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Link: https://lore.kernel.org/r/20220807115304.13257-1-fw@strlen.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 85b57473

drivers/net/plip/plip.c

+1 −1
Original line number Diff line number Diff line
@@ -1103,7 +1103,7 @@ plip_open(struct net_device *dev) 
		/* Any address will do - we take the first. We already

		   have the first two bytes filled with 0xfc, from

		   plip_init_dev(). */

		const struct in_ifaddr *ifa = rcu_dereference(in_dev->ifa_list);

		const struct in_ifaddr *ifa = rtnl_dereference(in_dev->ifa_list);

		if (ifa != NULL) {

			memcpy(dev->dev_addr+2, &ifa->ifa_local, 4);

		}