Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4ee1476 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

be2net: make two arrays static const, makes object smaller 



Don't populate the arrays on the stack but instead make them
static const. Makes the object code smaller by 281 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  87553	   5672	      0	  93225	  16c29	benet/be_cmds.o

After:
   text	   data	    bss	    dec	    hex	filename
  87112	   5832	      0	  92944	  16b10	benet/be_cmds.o

(gcc version 9.2.1, amd64)

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 52d56540

drivers/net/ethernet/emulex/benet/be_cmds.c

+2 −2
Original line number Diff line number Diff line
@@ -2756,7 +2756,7 @@ static int be_flash_BEx(struct be_adapter *adapter, 
	bool crc_match;

	const u8 *p;



	struct flash_comp gen3_flash_types[] = {

	static const struct flash_comp gen3_flash_types[] = {

		{ BE3_ISCSI_PRIMARY_IMAGE_START, OPTYPE_ISCSI_ACTIVE,

			BE3_COMP_MAX_SIZE, IMAGE_FIRMWARE_ISCSI},

		{ BE3_REDBOOT_START, OPTYPE_REDBOOT,
@@ -2779,7 +2779,7 @@ static int be_flash_BEx(struct be_adapter *adapter, 
			BE3_PHY_FW_COMP_MAX_SIZE, IMAGE_FIRMWARE_PHY}

	};



	struct flash_comp gen2_flash_types[] = {

	static const struct flash_comp gen2_flash_types[] = {

		{ BE2_ISCSI_PRIMARY_IMAGE_START, OPTYPE_ISCSI_ACTIVE,

			BE2_COMP_MAX_SIZE, IMAGE_FIRMWARE_ISCSI},

		{ BE2_REDBOOT_START, OPTYPE_REDBOOT,