Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f489eab5 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for nc_path near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent da7a26af

net/batman-adv/network-coding.c

+1 −1
Original line number Diff line number Diff line
@@ -978,7 +978,6 @@ static struct batadv_nc_path *batadv_nc_get_path(struct batadv_priv *bat_priv, 
	INIT_LIST_HEAD(&nc_path->packet_list);

	spin_lock_init(&nc_path->packet_list_lock);

	kref_init(&nc_path->refcount);

	kref_get(&nc_path->refcount);

	nc_path->last_valid = jiffies;

	ether_addr_copy(nc_path->next_hop, dst);

	ether_addr_copy(nc_path->prev_hop, src);
@@ -988,6 +987,7 @@ static struct batadv_nc_path *batadv_nc_get_path(struct batadv_priv *bat_priv, 
		   nc_path->next_hop);



	/* Add nc_path to hash table */

	kref_get(&nc_path->refcount);

	hash_added = batadv_hash_add(hash, batadv_nc_hash_compare,

				     batadv_nc_hash_choose, &nc_path_key,

				     &nc_path->hash_entry);