Commit f3fb802e authored Oct 23, 2019 by Roger Quadros Committed by Felipe Balbi Oct 27, 2019

usb: cdns3: gadget: Don't manage pullups



The USB gadget core is supposed to manage pullups
of the controller. Don't manage pullups from within
the controller driver. Otherwise, function drivers
are not able to keep the controller disconnected from
the bus till they are ready. (e.g. g_webcam)

Reviewed-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent a7d9874c

drivers/usb/cdns3/gadget.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2329,8 +2329,6 @@ static void cdns3_gadget_config(struct cdns3_device *priv_dev)
		writel(USB_CONF_CLK2OFFDS \| USB_CONF_L1DS, &regs->usb_conf);

		cdns3_configure_dmult(priv_dev, NULL);

		cdns3_gadget_pullup(&priv_dev->gadget, 1);
		}

		/**
		@@ -2713,8 +2711,6 @@ static int cdns3_gadget_suspend(struct cdns3 *cdns, bool do_wakeup)
		/* disable interrupt for device */
		writel(0, &priv_dev->regs->usb_ien);

		cdns3_gadget_pullup(&priv_dev->gadget, 0);

		return 0;
		}