Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f39f8688 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: synaptics - avoid using uninitialized variable when probing 



synaptics_detect() does not check whether sending commands to the
device succeeds and instead relies on getting unique data from the
device. Let's make sure we seed entire buffer with zeroes to make sure
we will not use garbage on stack that just happen to be 0x47.

Reported-by: default avatar <syzbot+13cb3b01d0784e4ffc3f@syzkaller.appspotmail.com>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 90237051

drivers/input/mouse/synaptics.c

+1 −3
Original line number Diff line number Diff line
@@ -99,9 +99,7 @@ static int synaptics_mode_cmd(struct psmouse *psmouse, u8 mode) 
int synaptics_detect(struct psmouse *psmouse, bool set_properties)

{

	struct ps2dev *ps2dev = &psmouse->ps2dev;

	u8 param[4];



	param[0] = 0;

	u8 param[4] = { 0 };



	ps2_command(ps2dev, param, PSMOUSE_CMD_SETRES);

	ps2_command(ps2dev, param, PSMOUSE_CMD_SETRES);