Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f360dcd4 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Bartosz Golaszewski
Browse files

gpio: mockup: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Bamvor Jian Zhang <bamv2005@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
[Bartosz: removed one more check for debugfs return value]
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 690499d9

drivers/gpio/gpio-mockup.c

+5 −16
Original line number Diff line number Diff line
@@ -315,7 +315,6 @@ static void gpio_mockup_debugfs_setup(struct device *dev, 
				      struct gpio_mockup_chip *chip)

{

	struct gpio_mockup_dbgfs_private *priv;

	struct dentry *evfile;

	struct gpio_chip *gc;

	const char *devname;

	char *name;
@@ -325,32 +324,25 @@ static void gpio_mockup_debugfs_setup(struct device *dev, 
	devname = dev_name(&gc->gpiodev->dev);



	chip->dbg_dir = debugfs_create_dir(devname, gpio_mockup_dbg_dir);

	if (IS_ERR_OR_NULL(chip->dbg_dir))

		goto err;



	for (i = 0; i < gc->ngpio; i++) {

		name = devm_kasprintf(dev, GFP_KERNEL, "%d", i);

		if (!name)

			goto err;

			return;



		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

		if (!priv)

			goto err;

			return;



		priv->chip = chip;

		priv->offset = i;

		priv->desc = &gc->gpiodev->descs[i];



		evfile = debugfs_create_file(name, 0200, chip->dbg_dir, priv,

		debugfs_create_file(name, 0200, chip->dbg_dir, priv,

				    &gpio_mockup_debugfs_ops);

		if (IS_ERR_OR_NULL(evfile))

			goto err;

	}



	return;



err:

	dev_err(dev, "error creating debugfs files\n");

}



static int gpio_mockup_name_lines(struct device *dev,
@@ -447,7 +439,6 @@ static int gpio_mockup_probe(struct platform_device *pdev) 
	if (rv)

		return rv;



	if (!IS_ERR_OR_NULL(gpio_mockup_dbg_dir))

	gpio_mockup_debugfs_setup(dev, chip);



	return 0;
@@ -501,8 +492,6 @@ static int __init gpio_mockup_init(void) 
	}



	gpio_mockup_dbg_dir = debugfs_create_dir("gpio-mockup", NULL);

	if (IS_ERR_OR_NULL(gpio_mockup_dbg_dir))

		gpio_mockup_err("error creating debugfs directory\n");



	err = platform_driver_register(&gpio_mockup_driver);

	if (err) {