Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2d2420b authored by Julia Lawall's avatar Julia Lawall Committed by Russell King
Browse files

SA1111: Eliminate use after free 

__sa1111_remove always frees its argument, so the subsequent reference to
sachip->saved_state represents a use after free.  __sa1111_remove does not
appear to use the saved_state field, so the patch simply frees it first.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E,E2;
@@

__sa1111_remove(E)
...
(
  E = E2
|
* E
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 74bc8093

arch/arm/common/sa1111.c

+2 −3
Original line number Diff line number Diff line
@@ -1028,13 +1028,12 @@ static int sa1111_remove(struct platform_device *pdev) 
	struct sa1111 *sachip = platform_get_drvdata(pdev);



	if (sachip) {

		__sa1111_remove(sachip);

		platform_set_drvdata(pdev, NULL);



#ifdef CONFIG_PM

		kfree(sachip->saved_state);

		sachip->saved_state = NULL;

#endif

		__sa1111_remove(sachip);

		platform_set_drvdata(pdev, NULL);

	}



	return 0;