Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1ff7c49 authored by Mauro Dreissig's avatar Mauro Dreissig Committed by Mauro Carvalho Chehab
Browse files

[media] staging: as102: Declare local variables as static 



As pointed out by sparse:
drivers/staging/media/as102/as102_fw.c:29:6: warning: symbol 'as102_st_fw1' was not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:30:6: warning: symbol 'as102_st_fw2' was not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:31:6: warning: symbol 'as102_dt_fw1' was not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:32:6: warning: symbol 'as102_dt_fw2' was not declared. Should it be static?
drivers/staging/media/as102/as102_usb_drv.c:194:25: warning: symbol 'as102_priv_ops' was not declared. Should it be static?
Also use the const qualifier on the firmware name strings.

Signed-off-by: default avatarMauro Dreissig <mukadr@gmail.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 2d012373

drivers/staging/media/as102/as102_fw.c

+5 −5
Original line number Diff line number Diff line
@@ -26,10 +26,10 @@ 
#include "as102_drv.h"

#include "as102_fw.h"



char as102_st_fw1[] = "as102_data1_st.hex";

char as102_st_fw2[] = "as102_data2_st.hex";

char as102_dt_fw1[] = "as102_data1_dt.hex";

char as102_dt_fw2[] = "as102_data2_dt.hex";

static const char as102_st_fw1[] = "as102_data1_st.hex";

static const char as102_st_fw2[] = "as102_data2_st.hex";

static const char as102_dt_fw1[] = "as102_data1_dt.hex";

static const char as102_dt_fw2[] = "as102_data2_dt.hex";



static unsigned char atohx(unsigned char *dst, char *src)

{
@@ -167,7 +167,7 @@ int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap) 
	int errno = -EFAULT;

	const struct firmware *firmware = NULL;

	unsigned char *cmd_buf = NULL;

	char *fw1, *fw2;

	const char *fw1, *fw2;

	struct usb_device *dev = bus_adap->usb_dev;



	ENTER();

drivers/staging/media/as102/as102_usb_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ static int as102_read_ep2(struct as10x_bus_adapter_t *bus_adap, 
	return ret ? ret : actual_len;

}



struct as102_priv_ops_t as102_priv_ops = {

static struct as102_priv_ops_t as102_priv_ops = {

	.upload_fw_pkt	= as102_send_ep1,

	.xfer_cmd	= as102_usb_xfer_cmd,

	.as102_read_ep2	= as102_read_ep2,