Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1e90f6e authored by Arthur Kiyanovski's avatar Arthur Kiyanovski Committed by David S. Miller
Browse files

net: ena: remove redundant parameter in ena_com_admin_init() 



Remove redundant spinlock acquire parameter from ena_com_admin_init()

Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 87731f0c

drivers/net/ethernet/amazon/ena/ena_com.c

+2 −4
Original line number Diff line number Diff line
@@ -1701,8 +1701,7 @@ void ena_com_mmio_reg_read_request_write_dev_addr(struct ena_com_dev *ena_dev) 
}



int ena_com_admin_init(struct ena_com_dev *ena_dev,

		       struct ena_aenq_handlers *aenq_handlers,

		       bool init_spinlock)

		       struct ena_aenq_handlers *aenq_handlers)

{

	struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;

	u32 aq_caps, acq_caps, dev_sts, addr_low, addr_high;
@@ -1728,7 +1727,6 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev, 


	atomic_set(&admin_queue->outstanding_cmds, 0);



	if (init_spinlock)

	spin_lock_init(&admin_queue->q_lock);



	ret = ena_com_init_comp_ctxt(admin_queue);

drivers/net/ethernet/amazon/ena/ena_com.h

+1 −4
Original line number Diff line number Diff line
@@ -436,8 +436,6 @@ void ena_com_mmio_reg_read_request_destroy(struct ena_com_dev *ena_dev); 
/* ena_com_admin_init - Init the admin and the async queues

 * @ena_dev: ENA communication layer struct

 * @aenq_handlers: Those handlers to be called upon event.

 * @init_spinlock: Indicate if this method should init the admin spinlock or

 * the spinlock was init before (for example, in a case of FLR).

 *

 * Initialize the admin submission and completion queues.

 * Initialize the asynchronous events notification queues.
@@ -445,8 +443,7 @@ void ena_com_mmio_reg_read_request_destroy(struct ena_com_dev *ena_dev); 
 * @return - 0 on success, negative value on failure.

 */

int ena_com_admin_init(struct ena_com_dev *ena_dev,

		       struct ena_aenq_handlers *aenq_handlers,

		       bool init_spinlock);

		       struct ena_aenq_handlers *aenq_handlers);



/* ena_com_admin_destroy - Destroy the admin and the async events queues.

 * @ena_dev: ENA communication layer struct

drivers/net/ethernet/amazon/ena/ena_netdev.c

+1 −1
Original line number Diff line number Diff line
@@ -2503,7 +2503,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev, 
	}



	/* ENA admin level init */

	rc = ena_com_admin_init(ena_dev, &aenq_handlers, true);

	rc = ena_com_admin_init(ena_dev, &aenq_handlers);

	if (rc) {

		dev_err(dev,

			"Can not initialize ena admin queue with device\n");