Commit f1b19006 authored Aug 19, 2019 by Nishka Dasgupta Committed by Felipe Balbi Aug 28, 2019

usb: phy: phy-fsl-usb: Make structure fsl_otg_initdata constant



Static structure fsl_otg_initdata, of type fsl_otg_config, is used only
once, when the value of its field otg_port is assigned to another
variable. As fsl_otg_initdata.otg_port is of type u8, any changes to
its copy do not affect the original, and fsl_otg_initdata itself is
never modified. Hence make fsl_otg_initdata constant to protect it from
unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent c33f1416

drivers/usb/phy/phy-fsl-usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -65,7 +65,7 @@ struct fsl_otg_timer b_data_pulse_tmr, b_vbus_pulse_tmr, *b_srp_fail_tmr,

		static struct list_head active_timers;

		static struct fsl_otg_config fsl_otg_initdata = {
		static const struct fsl_otg_config fsl_otg_initdata = {
		.otg_port = 1,
		};