Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f11aefc9 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

driver core: platform: fix u32 greater or equal to zero comparison 



[ Upstream commit 0707cfa5c3ef58effb143db9db6d6e20503f9dec ]

Currently the check that a u32 variable i is >= 0 is always true because
the unsigned variable will never be negative, causing the loop to run
forever.  Fix this by changing the pre-decrement check to a zero check on
i followed by a decrement of i.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 39cc539f90d0 ("driver core: platform: Prevent resouce overflow from causing infinite loops")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20200116175758.88396-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 843eb0a8

drivers/base/platform.c

+1 −1
Original line number Diff line number Diff line
@@ -543,7 +543,7 @@ int platform_device_add(struct platform_device *pdev) 
		pdev->id = PLATFORM_DEVID_AUTO;

	}



	while (--i >= 0) {

	while (i--) {

		struct resource *r = &pdev->resource[i];

		if (r->parent)

			release_resource(r);