Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f070b317 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

pwm: mediatek: Implement .apply() callback 



[ Upstream commit 758de66f4bd2cac2b1d71db917c65c3d611d4e74 ]

To eventually get rid of all legacy drivers convert this driver to the
modern world implementing .apply().
This just pushed a variant of pwm_apply_legacy() into the driver that was
slightly simplified because the driver doesn't provide a .set_polarity()
callback.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
Stable-dep-of: f21d136caf81 ("pwm: mediatek: Fix duty and period setting")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2964dbe6

drivers/pwm/pwm-mediatek.c

+26 −3
Original line number Diff line number Diff line
@@ -210,10 +210,33 @@ static void pwm_mediatek_disable(struct pwm_chip *chip, struct pwm_device *pwm) 
	pwm_mediatek_clk_disable(chip, pwm);

}



static int pwm_mediatek_apply(struct pwm_chip *chip, struct pwm_device *pwm,

			      const struct pwm_state *state)

{

	int err;



	if (state->polarity != PWM_POLARITY_NORMAL)

		return -EINVAL;



	if (!state->enabled) {

		if (pwm->state.enabled)

			pwm_mediatek_disable(chip, pwm);



		return 0;

	}



	err = pwm_mediatek_config(pwm->chip, pwm, state->duty_cycle, state->period);

	if (err)

		return err;



	if (!pwm->state.enabled)

		err = pwm_mediatek_enable(chip, pwm);



	return err;

}



static const struct pwm_ops pwm_mediatek_ops = {

	.config = pwm_mediatek_config,

	.enable = pwm_mediatek_enable,

	.disable = pwm_mediatek_disable,

	.apply = pwm_mediatek_apply,

	.owner = THIS_MODULE,

};