Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f00e4bfd authored Mar 13, 2023 by Patrik Dahlström Committed by Greg Kroah-Hartman May 17, 2023

iio: adc: palmas_gpadc: fix NULL dereference on rmmod



[ Upstream commit 49f76c499d38bf67803438eee88c8300d0f6ce09 ]

Calling dev_to_iio_dev() on a platform device pointer is undefined and
will make adc NULL.

Signed-off-by: Patrik Dahlström <risca@dalakolonin.se>
Link: https://lore.kernel.org/r/20230313205029.1881745-1-risca@dalakolonin.se


Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 85ed09c3

drivers/iio/adc/palmas_gpadc.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -630,7 +630,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev)

	static int palmas_gpadc_remove(struct platform_device *pdev)		static int palmas_gpadc_remove(struct platform_device *pdev)
	{		{
	struct iio_dev *indio_dev = dev_to_iio_dev(&pdev->dev);		struct iio_dev *indio_dev = dev_get_drvdata(&pdev->dev);
	struct palmas_gpadc *adc = iio_priv(indio_dev);		struct palmas_gpadc *adc = iio_priv(indio_dev);

	if (adc->wakeup1_enable \|\| adc->wakeup2_enable)		if (adc->wakeup1_enable \|\| adc->wakeup2_enable)