Commit efdf7511 authored Jul 04, 2018 by Vladimir Zapolskiy Committed by David S. Miller Jul 07, 2018

ravb: remove useless serialization in ravb_get_link_ksettings()



phy_ethtool_ksettings_get() call does not modify device state or device
driver state, hence there is no need to utilize a driver specific
spinlock.

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent eeb07284

drivers/net/ethernet/renesas/ravb_main.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1109,15 +1109,10 @@ static int ravb_phy_start(struct net_device *ndev)
		static int ravb_get_link_ksettings(struct net_device *ndev,
		struct ethtool_link_ksettings *cmd)
		{
		struct ravb_private *priv = netdev_priv(ndev);
		unsigned long flags;

		if (!ndev->phydev)
		return -ENODEV;

		spin_lock_irqsave(&priv->lock, flags);
		phy_ethtool_ksettings_get(ndev->phydev, cmd);
		spin_unlock_irqrestore(&priv->lock, flags);

		return 0;
		}