Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efd7be7b authored by Ulf Hansson's avatar Ulf Hansson
Browse files

mmc: tmio: Remove redundant check of mmc->slot.cd_irq 



To validate whether native hotplug needs to be used, the tmio driver checks
whether the mmc->slot.cd_irq has been successfully assigned.

This check is redundant at its current place in tmio_mmc_host_probe(), as
the mmc core assigns mmc->slot.cd_irq a valid value first when
mmc_gpiod_request_cd_irq() is called. Therefore, let's just remove the
check for now, as that also removes a layering violation of the tmio driver
accessing core specific data via ->slot.cd_irq.

Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent e87d2db2

drivers/mmc/host/tmio_mmc_pio.c

+1 −2
Original line number Diff line number Diff line
@@ -1175,8 +1175,7 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, 


	_host->native_hotplug = !(pdata->flags & TMIO_MMC_USE_GPIO_CD ||

				  mmc->caps & MMC_CAP_NEEDS_POLL ||

				  !mmc_card_is_removable(mmc) ||

				  mmc->slot.cd_irq >= 0);

				  !mmc_card_is_removable(mmc));



	/*

	 * On Gen2+, eMMC with NONREMOVABLE currently fails because native