Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efc60546 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Greg Kroah-Hartman
Browse files

NFS: remove unneeded check in decode_devicenotify_args() 

[ Upstream commit cb8fac6d2727f79f211e745b16c9abbf4d8be652 ]

[You don't often get email from khoroshilov@ispras.ru. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.

]

Overflow check in not needed anymore after we switch to kmalloc_array().

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: a4f743a6 ("NFSv4.1: Convert open-coded array allocation calls to kmalloc_array()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 110c0387

fs/nfs/callback_xdr.c

+0 −4
Original line number Diff line number Diff line
@@ -271,10 +271,6 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp, 
	n = ntohl(*p++);

	if (n == 0)

		goto out;

	if (n > ULONG_MAX / sizeof(*args->devs)) {

		status = htonl(NFS4ERR_BADXDR);

		goto out;

	}



	args->devs = kmalloc_array(n, sizeof(*args->devs), GFP_KERNEL);

	if (!args->devs) {