Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef1f3413 authored by Jan Beulich's avatar Jan Beulich Committed by Ingo Molnar
Browse files

x86: ticket spin locks: fix asm constraints 



In addition to these changes I doubt the 'volatile' on all the ticket
lock asm()-s are really necessary.

Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 0a328ea4

include/asm-x86/spinlock.h

+3 −3
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ static __always_inline int __ticket_spin_trylock(raw_spinlock_t *lock) 
		     "1:"

		     "sete %b1\n\t"

		     "movzbl %b1,%0\n\t"

		     : "=&a" (tmp), "=Q" (new), "+m" (lock->slock)

		     : "=&a" (tmp), "=&Q" (new), "+m" (lock->slock)

		     :

		     : "memory", "cc");
@@ -146,7 +146,7 @@ static __always_inline void __ticket_spin_lock(raw_spinlock_t *lock) 
		     /* don't need lfence here, because loads are in-order */

		     "jmp 1b\n"

		     "2:"

		     : "+Q" (inc), "+m" (lock->slock), "=r" (tmp)

		     : "+r" (inc), "+m" (lock->slock), "=&r" (tmp)

		     :

		     : "memory", "cc");

}
@@ -166,7 +166,7 @@ static __always_inline int __ticket_spin_trylock(raw_spinlock_t *lock) 
		     "1:"

		     "sete %b1\n\t"

		     "movzbl %b1,%0\n\t"

		     : "=&a" (tmp), "=r" (new), "+m" (lock->slock)

		     : "=&a" (tmp), "=&q" (new), "+m" (lock->slock)

		     :

		     : "memory", "cc");