Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee6b1889 authored by Stephen M. Cameron's avatar Stephen M. Cameron Committed by Christoph Hellwig
Browse files

hpsa: report check condition even if no sense data present for ioaccel2 mode 



It shouldn't happen that we get a check condition with no sense data, but if it
does, we shouldn't just drop the check condition on the floor.

Signed-off-by: default avatarStephen M. Cameron <scameron@beardog.cce.hp.com>
Reviewed-by: default avatarJustin Lindley <justin.lindley@hp.com>
Reviewed-by: default avatarMike Miller <michael.miller@canonical.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 8645291b

drivers/scsi/hpsa.c

+5 −2
Original line number Diff line number Diff line
@@ -1556,9 +1556,13 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h, 
			dev_warn(&h->pdev->dev,

				"%s: task complete with check condition.\n",

				"HP SSD Smart Path");

			cmd->result |= SAM_STAT_CHECK_CONDITION;

			if (c2->error_data.data_present !=

					IOACCEL2_SENSE_DATA_PRESENT)

					IOACCEL2_SENSE_DATA_PRESENT) {

				memset(cmd->sense_buffer, 0,

					SCSI_SENSE_BUFFERSIZE);

				break;

			}

			/* copy the sense data */

			data_len = c2->error_data.sense_data_len;

			if (data_len > SCSI_SENSE_BUFFERSIZE)
@@ -1568,7 +1572,6 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h, 
					sizeof(c2->error_data.sense_data_buff);

			memcpy(cmd->sense_buffer,

				c2->error_data.sense_data_buff, data_len);

			cmd->result |= SAM_STAT_CHECK_CONDITION;

			retry = 1;

			break;

		case IOACCEL2_STATUS_SR_TASK_COMP_BUSY: