Commit ee474b81 authored Nov 01, 2018 by Masami Hiramatsu Committed by Steven Rostedt (VMware) Nov 05, 2018

tracing/kprobes: Fix strpbrk() argument order

Fix strpbrk()'s argument order, it must pass acceptable string
in 2nd argument. Note that this can cause a kernel panic where
it recovers backup character to code->data.

Link: http://lkml.kernel.org/r/154108256792.2604.1816052586385217811.stgit@devbox

Fixes: a6682814 ("tracing/kprobes: Allow kprobe-events to record module symbol")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 65102238

kernel/trace/trace_probe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -535,7 +535,7 @@ int traceprobe_update_arg(struct probe_arg *arg)
		if (code[1].op != FETCH_OP_IMM)
		return -EINVAL;

		tmp = strpbrk("+-", code->data);
		tmp = strpbrk(code->data, "+-");
		if (tmp)
		c = *tmp;
		ret = traceprobe_split_symbol_offset(code->data,