Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee3dbcf9 authored by Ilia Lin's avatar Ilia Lin Committed by Rafael J. Wysocki
Browse files

cpufreq: kryo: Fix possible error code dereference 



In event of error returned by the nvmem_cell_read() non-pointer value
may be dereferenced. Fix this with error handling.
Additionally free the allocated speedbin buffer, as per the API.

Fixes: 9ce36edd1a52 (cpufreq: Add Kryo CPU scaling driver)
Signed-off-by: default avatarIlia Lin <ilia.lin@gmail.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent ce397d21

drivers/cpufreq/qcom-cpufreq-kryo.c

+3 −0
Original line number Diff line number Diff line
@@ -115,6 +115,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev) 


	speedbin = nvmem_cell_read(speedbin_nvmem, &len);

	nvmem_cell_put(speedbin_nvmem);

	if (IS_ERR(speedbin))

		return PTR_ERR(speedbin);



	switch (msm8996_version) {

	case MSM8996_V3:
@@ -127,6 +129,7 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev) 
		BUG();

		break;

	}

	kfree(speedbin);



	for_each_possible_cpu(cpu) {

		cpu_dev = get_cpu_device(cpu);