Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee1377c3 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

[STRIP]: Fix neighbour table refcount leak. 



Found by inspection. The STRIP driver does neigh_lookup() but never
releases.  This driver shouldn't being doing gratuitous arp anyway.

Untested, obviously, because of lack of hardware.

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57f5f544

drivers/net/wireless/strip.c

+4 −2
Original line number Diff line number Diff line
@@ -467,6 +467,7 @@ static int arp_query(unsigned char *haddr, u32 paddr, 
		     struct net_device *dev)

{

	struct neighbour *neighbor_entry;

	int ret = 0;



	neighbor_entry = neigh_lookup(&arp_tbl, &paddr, dev);
@@ -474,10 +475,11 @@ static int arp_query(unsigned char *haddr, u32 paddr, 
		neighbor_entry->used = jiffies;

		if (neighbor_entry->nud_state & NUD_VALID) {

			memcpy(haddr, neighbor_entry->ha, dev->addr_len);

			return 1;

			ret = 1;

		}

		neigh_release(neighbor_entry);

	}

	return 0;

	return ret;

}



static void DumpData(char *msg, struct strip *strip_info, __u8 * ptr,