Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edea7148 authored by Cyrill Gorcunov's avatar Cyrill Gorcunov Committed by Ingo Molnar
Browse files

x86: irq.c - tiny cleanup 



Impact: cleanup, robustization

 1) guard ack_bad_irq with printk_ratelimit since there is no
    guarantee we will not be flooded one day

 2) use pr_emerg() helper

Signed-off-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
LKML-Reference: <20090412165058.277579847@openvz.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 47f16ca7

arch/x86/kernel/irq.c

+5 −4
Original line number Diff line number Diff line
@@ -24,7 +24,8 @@ void (*generic_interrupt_extension)(void) = NULL; 
 */

void ack_bad_irq(unsigned int irq)

{

	printk(KERN_ERR "unexpected IRQ trap at vector %02x\n", irq);

	if (printk_ratelimit())

		pr_err("unexpected IRQ trap at vector %02x\n", irq);



#ifdef CONFIG_X86_LOCAL_APIC

	/*
@@ -219,7 +220,7 @@ unsigned int __irq_entry do_IRQ(struct pt_regs *regs) 
#endif



		if (printk_ratelimit())

			printk(KERN_EMERG "%s: %d.%d No irq handler for vector (irq %d)\n",

			pr_emerg("%s: %d.%d No irq handler for vector (irq %d)\n",

				__func__, smp_processor_id(), vector, irq);

	}