Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ede990cf authored by Jianglei Nie's avatar Jianglei Nie Committed by Greg Kroah-Hartman
Browse files

net: sfp: fix memory leak in sfp_probe() 



[ Upstream commit 0a18d802d65cf662644fd1d369c86d84a5630652 ]

sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When
devm_add_action() fails, sfp is not freed, which leads to a memory leak.

We should use devm_add_action_or_reset() instead of devm_add_action().

Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/20220629075550.2152003-1-niejianglei2021@163.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 555cee1b

drivers/net/phy/sfp.c

+1 −1
Original line number Diff line number Diff line
@@ -1878,7 +1878,7 @@ static int sfp_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, sfp);



	err = devm_add_action(sfp->dev, sfp_cleanup, sfp);

	err = devm_add_action_or_reset(sfp->dev, sfp_cleanup, sfp);

	if (err < 0)

		return err;