Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ede0334b authored by Qiheng Lin's avatar Qiheng Lin Committed by Greg Kroah-Hartman
Browse files

ARM: zynq: Fix refcount leak in zynq_early_slcr_init 



[ Upstream commit 9eedb910a3be0005b88c696a8552c0d4c9937cd4 ]

of_find_compatible_node() returns a node pointer with refcount incremented,
we should use of_node_put() on error path.
Add missing of_node_put() to avoid refcount leak.

Fixes: 3329659d ("ARM: zynq: Simplify SLCR initialization")
Signed-off-by: default avatarQiheng Lin <linqiheng@huawei.com>
Link: https://lore.kernel.org/r/20221129140544.41293-1-linqiheng@huawei.com


Signed-off-by: default avatarMichal Simek <michal.simek@amd.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 45b44ba5

arch/arm/mach-zynq/slcr.c

+1 −0
Original line number Diff line number Diff line
@@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void) 
	zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");

	if (IS_ERR(zynq_slcr_regmap)) {

		pr_err("%s: failed to find zynq-slcr\n", __func__);

		of_node_put(np);

		return -ENODEV;

	}