Commit eda220ac authored Mar 28, 2016 by Shuah Khan Committed by Mauro Carvalho Chehab May 09, 2016

[media] media: au0828 fix au0828_v4l2_device_register() to not unlock and free



au0828_v4l2_device_register() unlocks au0828_dev->lock and frees au0828
dev in error legs before return. au0828_usb_probe() does the same when
au0828_v4l2_device_register() returns error.

Fix au0828_v4l2_device_register() to not to unlock and free in its error
legs.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent c23ac90f

drivers/media/usb/au0828/au0828-video.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -679,8 +679,6 @@ int au0828_v4l2_device_register(struct usb_interface *interface,
		if (retval) {
		pr_err("%s() v4l2_device_register failed\n",
		__func__);
		mutex_unlock(&dev->lock);
		kfree(dev);
		return retval;
		}

		@@ -691,8 +689,6 @@ int au0828_v4l2_device_register(struct usb_interface *interface,
		if (retval) {
		pr_err("%s() v4l2_ctrl_handler_init failed\n",
		__func__);
		mutex_unlock(&dev->lock);
		kfree(dev);
		return retval;
		}
		dev->v4l2_dev.ctrl_handler = &dev->v4l2_ctrl_hdl;