Commit ed9b2ad3 authored Sep 15, 2023 by Dan Carpenter Committed by Greg Kroah-Hartman Nov 20, 2023

dmaengine: ti: edma: handle irq_of_parse_and_map() errors



[ Upstream commit 14f6d317913f634920a640e9047aa2e66f5bdcb7 ]

Zero is not a valid IRQ for in-kernel code and the irq_of_parse_and_map()
function returns zero on error.  So this check for valid IRQs should only
accept values > 0.

Fixes: 2b6b3b74 ("ARM/dmaengine: edma: Merge the two drivers under drivers/dma/")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/f15cb6a7-8449-4f79-98b6-34072f04edbc@moroto.mountain


Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 64c47749

drivers/dma/ti/edma.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2361,7 +2361,7 @@ static int edma_probe(struct platform_device *pdev)
		if (irq < 0 && node)
		irq = irq_of_parse_and_map(node, 0);

		if (irq >= 0) {
		if (irq > 0) {
		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint",
		dev_name(dev));
		ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
		@@ -2377,7 +2377,7 @@ static int edma_probe(struct platform_device *pdev)
		if (irq < 0 && node)
		irq = irq_of_parse_and_map(node, 2);

		if (irq >= 0) {
		if (irq > 0) {
		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint",
		dev_name(dev));
		ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,