Commit ed79dac9 authored Mar 22, 2019 by Darrick J. Wong

xfs: prohibit fstrim in norecovery mode



The xfs fstrim implementation uses the free space btrees to find free
space that can be discarded.  If we haven't recovered the log, the bnobt
will be stale and we absolutely *cannot* use stale metadata to zap the
underlying storage.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>

parent 4b0bce30

fs/xfs/xfs_discard.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -161,6 +161,14 @@ xfs_ioc_trim(
		return -EPERM;
		if (!blk_queue_discard(q))
		return -EOPNOTSUPP;

		/*
		* We haven't recovered the log, so we cannot use our bnobt-guided
		* storage zapping commands.
		*/
		if (mp->m_flags & XFS_MOUNT_NORECOVERY)
		return -EROFS;

		if (copy_from_user(&range, urange, sizeof(range)))
		return -EFAULT;