Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecd48968 authored by Narendra Hadke's avatar Narendra Hadke Committed by Greg Kroah-Hartman
Browse files

serial: mvebu-uart: uart2 error bits clearing 



commit a7209541239e5dd44d981289e5f9059222d40fd1 upstream.

For mvebu uart2, error bits are not cleared on buffer read.
This causes interrupt loop and system hang.

Cc: stable@vger.kernel.org
Reviewed-by: default avatarYi Guo <yi.guo@cavium.com>
Reviewed-by: default avatarNadav Haklai <nadavh@marvell.com>
Signed-off-by: default avatarNarendra Hadke <nhadke@marvell.com>
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20220726091221.12358-1-pali@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d11e3f4f

drivers/tty/serial/mvebu-uart.c

+11 −0
Original line number Diff line number Diff line
@@ -238,6 +238,7 @@ static void mvebu_uart_rx_chars(struct uart_port *port, unsigned int status) 
	struct tty_port *tport = &port->state->port;

	unsigned char ch = 0;

	char flag = 0;

	int ret;



	do {

		if (status & STAT_RX_RDY(port)) {
@@ -250,6 +251,16 @@ static void mvebu_uart_rx_chars(struct uart_port *port, unsigned int status) 
				port->icount.parity++;

		}



		/*

		 * For UART2, error bits are not cleared on buffer read.

		 * This causes interrupt loop and system hang.

		 */

		if (IS_EXTENDED(port) && (status & STAT_BRK_ERR)) {

			ret = readl(port->membase + UART_STAT);

			ret |= STAT_BRK_ERR;

			writel(ret, port->membase + UART_STAT);

		}



		if (status & STAT_BRK_DET) {

			port->icount.brk++;

			status &= ~(STAT_FRM_ERR | STAT_PAR_ERR);