Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eca19dc1 authored by Israel Rukshin's avatar Israel Rukshin Committed by Christoph Hellwig
Browse files

nvmet: fix error flow in nvmet_alloc_ctrl() 



Remove the allocated id on error.

Signed-off-by: default avatarIsrael Rukshin <israelr@mellanox.com>
Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6fbcde66

drivers/nvme/target/core.c

+3 −1
Original line number Diff line number Diff line
@@ -830,7 +830,7 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn, 
		/* Don't accept keep-alive timeout for discovery controllers */

		if (kato) {

			status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;

			goto out_free_sqs;

			goto out_remove_ida;

		}



		/*
@@ -860,6 +860,8 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn, 
	*ctrlp = ctrl;

	return 0;



out_remove_ida:

	ida_simple_remove(&cntlid_ida, ctrl->cntlid);

out_free_sqs:

	kfree(ctrl->sqs);

out_free_cqs: