Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec641b39 authored by Yuchung Cheng's avatar Yuchung Cheng Committed by David S. Miller
Browse files

tcp: fix SNMP under-estimation on failed retransmission 



Previously the SNMP counter LINUX_MIB_TCPRETRANSFAIL is not counting
the TSO/GSO properly on failed retransmission. This patch fixes that.

Signed-off-by: default avatarYuchung Cheng <ycheng@google.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarNeal Cardwell <ncardwell@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3976535a

net/ipv4/tcp_output.c

+1 −1
Original line number Diff line number Diff line
@@ -2920,7 +2920,7 @@ int __tcp_retransmit_skb(struct sock *sk, struct sk_buff *skb, int segs) 
		TCP_SKB_CB(skb)->sacked |= TCPCB_EVER_RETRANS;

		trace_tcp_retransmit_skb(sk, skb);

	} else if (err != -EBUSY) {

		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL);

		NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL, segs);

	}

	return err;

}