Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebaf1908 authored by Weihang Li's avatar Weihang Li Committed by David S. Miller
Browse files

net: hns3: some variable modification 



This patch does following things:
1. add the keyword const before some variables which won't be modified
   in functions.
2. changes some variables from signed to unsigned to avoid bitwise
   operation on signed variables.
3. adds or removes initialization of some variables.
4. defines a new structure to help parsing mailbox messages instead of
   using an array which is harder to get the meaning of each element.

Signed-off-by: default avatarWeihang Li <liweihang@hisilicon.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: default avatarYufeng Mo <moyufeng@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a30964a

drivers/net/ethernet/hisilicon/hns3/hnae3.c

+2 −1
Original line number Diff line number Diff line
@@ -26,7 +26,8 @@ static bool hnae3_client_match(enum hnae3_client_type client_type) 
}



void hnae3_set_client_init_flag(struct hnae3_client *client,

				struct hnae3_ae_dev *ae_dev, int inited)

				struct hnae3_ae_dev *ae_dev,

				unsigned int inited)

{

	if (!client || !ae_dev)

		return;

drivers/net/ethernet/hisilicon/hns3/hnae3.h

+3 −2
Original line number Diff line number Diff line
@@ -493,7 +493,7 @@ struct hnae3_ae_ops { 
	void (*enable_fd)(struct hnae3_handle *handle, bool enable);

	int (*add_arfs_entry)(struct hnae3_handle *handle, u16 queue_id,

			      u16 flow_id, struct flow_keys *fkeys);

	int (*dbg_run_cmd)(struct hnae3_handle *handle, char *cmd_buf);

	int (*dbg_run_cmd)(struct hnae3_handle *handle, const char *cmd_buf);

	pci_ers_result_t (*handle_hw_ras_error)(struct hnae3_ae_dev *ae_dev);

	bool (*get_hw_reset_stat)(struct hnae3_handle *handle);

	bool (*ae_dev_resetting)(struct hnae3_handle *handle);
@@ -645,5 +645,6 @@ void hnae3_unregister_client(struct hnae3_client *client); 
int hnae3_register_client(struct hnae3_client *client);



void hnae3_set_client_init_flag(struct hnae3_client *client,

				struct hnae3_ae_dev *ae_dev, int inited);

				struct hnae3_ae_dev *ae_dev,

				unsigned int inited);

#endif

drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c

+3 −2
Original line number Diff line number Diff line
@@ -11,7 +11,8 @@ 


static struct dentry *hns3_dbgfs_root;



static int hns3_dbg_queue_info(struct hnae3_handle *h, char *cmd_buf)

static int hns3_dbg_queue_info(struct hnae3_handle *h,

			       const char *cmd_buf)

{

	struct hns3_nic_priv *priv = h->priv;

	struct hns3_nic_ring_data *ring_data;
@@ -155,7 +156,7 @@ static int hns3_dbg_queue_map(struct hnae3_handle *h) 
	return 0;

}



static int hns3_dbg_bd_info(struct hnae3_handle *h, char *cmd_buf)

static int hns3_dbg_bd_info(struct hnae3_handle *h, const char *cmd_buf)

{

	struct hns3_nic_priv *priv = h->priv;

	struct hns3_nic_ring_data *ring_data;

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+3 −2
Original line number Diff line number Diff line
@@ -1011,7 +1011,8 @@ static int hns3_fill_desc_vtags(struct sk_buff *skb, 
}



static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv,

			  int size, int frag_end, enum hns_desc_type type)

			  unsigned int size, int frag_end,

			  enum hns_desc_type type)

{

	struct hns3_desc_cb *desc_cb = &ring->desc_cb[ring->next_to_use];

	struct hns3_desc *desc = &ring->desc[ring->next_to_use];
@@ -3424,7 +3425,7 @@ static int hns3_nic_dealloc_vector_data(struct hns3_nic_priv *priv) 
}



static int hns3_ring_get_cfg(struct hnae3_queue *q, struct hns3_nic_priv *priv,

			     int ring_type)

			     unsigned int ring_type)

{

	struct hns3_nic_ring_data *ring_data = priv->ring_data;

	int queue_num = priv->ae_handle->kinfo.num_tqps;

drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

+1 −1
Original line number Diff line number Diff line
@@ -417,7 +417,7 @@ struct hns3_enet_ring { 
	 */

	int next_to_clean;



	int pull_len; /* head length for current packet */

	u32 pull_len; /* head length for current packet */

	u32 frag_num;

	unsigned char *va; /* first buffer address for current packet */